Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScreenView visibleProperty should not be featured #332

Closed
pixelzoom opened this issue May 6, 2023 · 2 comments
Closed

ScreenView visibleProperty should not be featured #332

pixelzoom opened this issue May 6, 2023 · 2 comments
Assignees
Labels
design:phet-io type:bug Something isn't working

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented May 6, 2023

Noticed when migrating overrides.js into code for #331.

In natural-selection-overrides.js, I see that the visibleProperty of both ScreenViews is featured:

    "naturalSelection.introScreen.view.visibleProperty": {
      "phetioFeatured": true
    },
    "naturalSelection.labScreen.view.visibleProperty": {
      "phetioFeatured": true
    }

This seems odd, because

  • these visiblePropetyelements are phetioReadOnly: true
  • no other sims feature this Property (search all overrides.js for "Screen.view.visibleProperty" to confirm)

@amanda-phet was this intentional, or is this a bug? I recommend not featuring these elements.

@pixelzoom pixelzoom added type:bug Something isn't working design:phet-io labels May 6, 2023
@pixelzoom pixelzoom changed the title naturalSelection.*Screen.view.visibleProperty should not be featured ScreenView visibleProperty should not be featured May 6, 2023
@amanda-phet
Copy link
Contributor

I have no recollection of featuring this, and can't understand why it's featured (being read-only). Please un-feature!

@pixelzoom
Copy link
Contributor Author

pixelzoom commented May 15, 2023

Done in the above commits. view.visibleProperty is now phetioFeatured: false for both screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design:phet-io type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants