problems with deployment of older maintenance release #8
Comments
|
There was an problem identified a while back where the build server was not rebuilding translations when This issue was discussed in the 1/19/2016 design meeting, and I floated the idea of modifying the build server to automatically detect the case where the pre-fix version of chipper is being used and in that case interpret |
|
For reference, the commit to chipper that made |
|
@jbphet said:
This "quirk" is actually a bug. According to the Grunt FAQ (http://gruntjs.com/frequently-asked-questions):
But that's not actually the case, it's buggy, see gruntjs/grunt-cli#45. |
…bout the unique behavior of older versions of chipper, see phetsims/perennial#8 and phetsims/rosetta#101
|
Below is a list of the simulations whose most recent branch with a numerical name (e.g. 1.2) contain a version of chipper from prior to Nov 10 2015, and thus would need to have maintenance releases deployed with the
[EDIT: * sim will be redeployed from master as part of S2015R https://github.com/phetsims/tasks/issues/476) That's 26 simulations, which seems like a lot to me. Some will be redeployed at some point for translation, but some of the sims on this list were released after the translation hooks were added but before this change was made to chipper. |
|
I wrote a bash script to print the date of the chipper version for the most recent numerical branch for all active sims. I'm disinclined to check it into github, so I thought I'd just paste it below in case it is ever needed again. This is not particularly robust (it assumes that branch numbers are printed out in order, which was the case on my system, but may not be on others), and I haven't done much bash so it's probably not pretty either, but it got me what I needed. #!/bin/bash
#=======================================================================================
#
# temp script for helping to find branches with old versions of chipper
#
#=======================================================================================
CHIPPER_BIN=`dirname "${BASH_SOURCE[0]}"`
WORKING_DIR=${CHIPPER_BIN}/../..
cd ${WORKING_DIR}
# list of active sim repos
ACTIVE_SIMS=`cat ./chipper/data/active-sims | dos2unix`
# loop through each active sim repo
for repo in ${ACTIVE_SIMS}
do
cd ${repo}
branches=`git branch -r`
highestBranchNumber="0"
# find the branches that contain a period, and record the highest value of such a branch name
for branch in ${branches}
do
trimmedBranchName=${branch/origin\//}
if [[ ${trimmedBranchName} == *"."* ]]
then
highestBranchNumber=${trimmedBranchName}
fi
done
# if a branch was found, extract the chipper SHA
if [[ ${highestBranchNumber} != "0" ]]
then
# check out the branch
git checkout --quiet ${highestBranchNumber}
# get the line in the dependencies file that contains the needed SHA
chipperSha="$(cat ./dependencies.json | grep -A1 chipper | grep sha)"
# trim off the leading "sha": portion
chipperSha=${chipperSha/\"sha\": \"/}
# trim off the trailing comma and quotation mark
chipperSha=${chipperSha/\",/}
# look up the date for this SHA in chipper
cd ../chipper
logData="$(git log --pretty=format:"%H %cd" | grep ${chipperSha})"
echo ${repo} ${logData}
fi
cd ..
done |
|
Meeting consensus: @jbphet will change the how-to-deploy-maintenance-release documentation to make sure We will also need to be careful about making API-level changes to build-server or perennial. @jbphet also proposed adding a version field to the command message. If something doesn't have "version", then it predates these changes and will hence need |
|
Documentation has been updated and a maintenance release was completed successfully (Arithmetic). Work is done for this, closing. |
On Monday, January 11, 2016, @pixelzoom attempted to deploy a maintenance release for Beer's Law Lab, but the existing translations did not get properly rebuild and redeployed. Below is the Skype dialog that chronicles the discussion. This is here mainly for record keeping, and I'll try to summarize the problem and solution(s) in subsequent comments.
The text was updated successfully, but these errors were encountered: