-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undesirable workaround for Audio preferences. #215
Labels
Comments
This was discussed a bit yesterday, but I don't recall the conclusion. |
The conclusion was:
|
I opened the Joist issue and pointed TODOs at it. Closing. |
samreid
added a commit
that referenced
this issue
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For code review #32 ...
In projectile-data-lab-main.ts, a blank Node is being created for the left column of the Audio preferences tab, to workaround a joist layout problem -- see relevant code below. Rather than creating an undesirable dependency on bad layout behavior, it would be preferrable to fix the layout problem in joist. Or at least open a GitHub issue for the problem, with a TODO here, so that the problem may eventually get fixed, and someone will know to remove this workaround.
The text was updated successfully, but these errors were encountered: