Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undesirable workaround for Audio preferences. #215

Closed
pixelzoom opened this issue Mar 3, 2024 · 3 comments
Closed

Undesirable workaround for Audio preferences. #215

pixelzoom opened this issue Mar 3, 2024 · 3 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

For code review #32 ...

In projectile-data-lab-main.ts, a blank Node is being created for the left column of the Audio preferences tab, to workaround a joist layout problem -- see relevant code below. Rather than creating an undesirable dependency on bad layout behavior, it would be preferrable to fix the layout problem in joist. Or at least open a GitHub issue for the problem, with a TODO here, so that the problem may eventually get fixed, and someone will know to remove this workaround.

    audioOptions: {
      customPreferences: [
        {

          // Due to the layout considerations in the Preferences Dialog, it has 2 columns. Our entry for the left column
          // is blank
          createContent: () => new Node()
        },
        {
        createContent: tandem => new AudioPreferencesContentNode( tandem.createTandem( 'audioPreferences' ) )
      } ]
@samreid
Copy link
Member

samreid commented Mar 5, 2024

This was discussed a bit yesterday, but I don't recall the conclusion.

@samreid samreid removed their assignment Mar 5, 2024
@pixelzoom
Copy link
Contributor Author

The conclusion was:

  • Open a joist issue for improving the audioOptions.customPreferences API, so that this type of workaround is not needed.
  • Leave the workaround in place. Add a TODO comment that links to the joist issue, so that future improvement of the API will also address the workaround in PDL.

@samreid
Copy link
Member

samreid commented Mar 6, 2024

I opened the Joist issue and pointed TODOs at it. Closing.

@samreid samreid closed this as completed Mar 6, 2024
samreid added a commit that referenced this issue Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants