Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launching from studio does not work #385

Closed
KatieWoe opened this issue May 3, 2021 · 6 comments
Closed

Launching from studio does not work #385

KatieWoe opened this issue May 3, 2021 · 6 comments
Assignees
Labels
dev:phet-io type:bug Something isn't working

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented May 3, 2021

For phetsims/qa#647. Win 10 Chrome.
When in studio, if you launch the sim, the resulting sim freezes on the home screen and creates several issues in the console. If you launch without entering the sim, trying to enter the resulting launched sim will then create the freezed behavior.
can't preview

@KatieWoe KatieWoe added the type:bug Something isn't working label May 3, 2021
@zepumph
Copy link
Member

zepumph commented May 3, 2021

Good catch! Thanks.

@zepumph
Copy link
Member

zepumph commented May 3, 2021

This is just a general problem with setting state. I'm not sure I had gotten to state just yet, as we are only supporting recording at this time. I'll keep you posted on priority of this.

@KatieWoe
Copy link
Contributor Author

KatieWoe commented May 4, 2021

Yup, confirming this is a problem in the state wrapper too.

zepumph added a commit that referenced this issue May 4, 2021
zepumph added a commit to phetsims/tandem that referenced this issue May 4, 2021
@zepumph
Copy link
Member

zepumph commented May 4, 2021

The problem was that my fromStateObject was on the prototype, and not a static. I'm a bit embarrassed by how long this took me to debug. As a result I added an assertion in IOType.fromCoreType.

@samreid let me know if you can foresee trouble with that assertion.

zepumph added a commit that referenced this issue May 4, 2021
@zepumph zepumph closed this as completed May 4, 2021
@zepumph
Copy link
Member

zepumph commented May 4, 2021

Cherry picked into 1.1 (for the study this week). Closing

@samreid
Copy link
Member

samreid commented May 4, 2021

The assertion looks correct to me, and unlikely to yield any false positivise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:phet-io type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants