Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest version not correctly identified #137

Closed
jbphet opened this issue Sep 26, 2016 · 2 comments
Closed

latest version not correctly identified #137

jbphet opened this issue Sep 26, 2016 · 2 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Sep 26, 2016

We recently received a report that some of the translations for the Molecules and Light simulation had disappeared from the web site. After some investigation, I found that it was due to a problem where Rosetta was not correctly recognizing that version 1.1.10 comes after 1.1.9. This is because it was relying on the order in with directory names are sorted by the JavaScript Array.sort() function, which is sorts lexicographically since the directory names are strings. This caused version 1.1.9 to be re-published, which had a problem with the translations due to the issue reported here: phetsims/perennial#23.

jbphet added a commit that referenced this issue Sep 26, 2016
jbphet added a commit to phetsims/molecules-and-light that referenced this issue Sep 26, 2016
@jbphet
Copy link
Contributor Author

jbphet commented Sep 26, 2016

I looked around and the other sims and verified that none of them have gotten to version x.x.10 other than Molecules and Light, so no other sim pages and deployments will need to be fixed up as a result of this.

@jbphet
Copy link
Contributor Author

jbphet commented Nov 18, 2016

This appears to be working correctly now, since we haven't had any recurrences of the issue for a while. While this doesn't constitute definitive proof that the problem is solved, I feel pretty good about the solution and am comfortable closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant