Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted translators not appearing in credits #83

Closed
aaronsamuel137 opened this issue Sep 29, 2015 · 3 comments
Closed

Trusted translators not appearing in credits #83

aaronsamuel137 opened this issue Sep 29, 2015 · 3 comments
Assignees

Comments

@aaronsamuel137
Copy link
Contributor

Not sure why, but none of them have been appearing the credits in the beta test. When Ariel or I test, the credits seem to work fine.

Not sure how to fix it, since I can't reproduce it currently. Maybe something was broken during the testing period that has since been fixed?

I'll make a note to look into this as soon as trusted translators start on the main site.

@aaronsamuel137 aaronsamuel137 self-assigned this Oct 27, 2015
@aaronsamuel137
Copy link
Contributor Author

The translator won't appear in the credits if it is the first time that a locale is translated. This is because the build-server hasn't had the time to deploy the translation to the website before this happens, and therefore there LocalizedSimulation doesn't exist in the database yet to add the translator to.

I'll investigate other ways of doing this. We may need to create another API on the website for doing this, which will be a little bit of work.

@aaronsamuel137
Copy link
Contributor Author

I think this is fixed now. I moved the code that adds the translator credits to the database from rosetta to build server. The should fix the order dependency.

I'll wait until another translation attempt before closing this to verify it is fixed.

In the mean time, I have manually added all of the translator credits that should have been added thus far.

@aaronsamuel137
Copy link
Contributor Author

Appears to be fixed now, I've seen new translation credits appear. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant