-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entries in third-party-licenses.json should have suffixes #34
Comments
This means we will also need suffices in build.json in this block: "licenseKeys": [
"almond-0.2.9",
"fontawesome-webfont-3.0.2",
"jama-1.0.2",
"pegjs-0.7.0",
"text-2.0.12"
] Not sure if we will have to make any changes to sim package.json files because of this. |
You'll also need to look at any licenseKeys entries in package.json for individual sims. |
I can't find any licenseKeys entries in package.json for individual sims. Am I doing this right? |
In the above commit, I added the suffixes and removed the logic that was stripping *.js in chipper. I tested building forces-and-motion-basics and launching it and didn't see any new problems. Reassigning to @pixelzoom to see if there's anything else to do for this issue and to conclude our conversation above in #34 (comment) |
One more issue: in the above, there is now a string "jama-1.0.2.js" but unfortunately there is no such file. |
There may not be any licenseKeys yet in package.json for individual sims. They're only needed for sim-specific 3rd-party libs that aren't specified in preload. |
OK, thanks. I'll move the JAMA problem to a new issue and close this one. |
For instance: fontawesome-webfont-3.0.2.svg instead of fontawesome-webfont-3.0.2
The text was updated successfully, but these errors were encountered: