Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entries in third-party-licenses.json should have suffixes #34

Closed
samreid opened this issue Jun 19, 2015 · 7 comments
Closed

entries in third-party-licenses.json should have suffixes #34

samreid opened this issue Jun 19, 2015 · 7 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Jun 19, 2015

For instance: fontawesome-webfont-3.0.2.svg instead of fontawesome-webfont-3.0.2

@samreid
Copy link
Member Author

samreid commented Jul 6, 2015

This means we will also need suffices in build.json in this block:

    "licenseKeys": [
      "almond-0.2.9",
      "fontawesome-webfont-3.0.2",
      "jama-1.0.2",
      "pegjs-0.7.0",
      "text-2.0.12"
    ]

Not sure if we will have to make any changes to sim package.json files because of this.

@pixelzoom
Copy link
Contributor

You'll also need to look at any licenseKeys entries in package.json for individual sims.

@samreid
Copy link
Member Author

samreid commented Jul 6, 2015

I can't find any licenseKeys entries in package.json for individual sims. Am I doing this right?

samreid added a commit to phetsims/chipper that referenced this issue Jul 6, 2015
@samreid
Copy link
Member Author

samreid commented Jul 6, 2015

In the above commit, I added the suffixes and removed the logic that was stripping *.js in chipper. I tested building forces-and-motion-basics and launching it and didn't see any new problems. Reassigning to @pixelzoom to see if there's anything else to do for this issue and to conclude our conversation above in #34 (comment)

@samreid samreid assigned pixelzoom and unassigned samreid Jul 6, 2015
@samreid
Copy link
Member Author

samreid commented Jul 6, 2015

One more issue: in the above, there is now a string "jama-1.0.2.js" but unfortunately there is no such file.

@pixelzoom
Copy link
Contributor

There may not be any licenseKeys yet in package.json for individual sims. They're only needed for sim-specific 3rd-party libs that aren't specified in preload.

@samreid
Copy link
Member Author

samreid commented Jul 6, 2015

OK, thanks. I'll move the JAMA problem to a new issue and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants