Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new names and symbols for elements with atomic number: 113, 115, 117 and 118 #22

Open
jgpATs2w opened this issue Jun 22, 2017 · 8 comments

Comments

@jgpATs2w
Copy link

jgpATs2w commented Jun 22, 2017

On June 2016 IUPAC announced new symbols and names (i.e. for 113 https://www.webelements.com/nihonium/).
I've detected the issue in build an atom 1.2.5, but looking at the code the symbols should be updated in this repo, at AtomIdentifier.js, symbolTable. Those are the new lines:

    'Nh', // 113, NIHONIUM
    'Fl', // 114, FLEROVIUM
    'Mc', // 115, MOSCOVIUM
    'Lv', // 116, LIVERMORIUM
    'Ts', // 117, TENNESSINE
    'Og'  // 118, OGANESSON
@jessegreenberg
Copy link
Contributor

Thanks @jgpATs2w. @ariel-phet could you please review and assign someone to work on this issue?

@jbphet
Copy link
Contributor

jbphet commented Jul 18, 2017

Here is a link to an announcement about this: https://iupac.org/iupac-announces-the-names-of-the-elements-113-115-117-and-118/

@jbphet
Copy link
Contributor

jbphet commented Jul 18, 2017

Here is a snapshot of the periodic table from v1.2.5 of BAA, which is live on the web site as of this writing:

baa-table-before

@jbphet
Copy link
Contributor

jbphet commented Jul 18, 2017

Here is what it looks like with the modifications in place:

baa-table-after

jbphet added a commit that referenced this issue Jul 18, 2017
@jbphet
Copy link
Contributor

jbphet commented Jul 18, 2017

The suggested changes have been made. There is currently an RC under test for Build an Atom, it would be good to get this change into it since it may be a long time before another release is done. Assigning to @jessegreenberg to make sure that this happens.

@jbphet jbphet assigned jessegreenberg and unassigned jbphet Jul 18, 2017
jessegreenberg added a commit to phetsims/build-an-atom that referenced this issue Jul 20, 2017
@jessegreenberg
Copy link
Contributor

Added to the 1.6 branch, thanks @jbphet. Closing.

@jbphet
Copy link
Contributor

jbphet commented Sep 13, 2017

I renamed the symbols, but it looks like I didn't do the element names. This isn't a big deal in the normal use of the sim because the sim never shows element names above atomic number 99. However, while working on instrumentation of the BAA game (see phetsims/build-an-atom#156), we decided to use the element name in the data stream. Now, the element name on the periodic table in the stream doesn't match the symbol used for elements 113, 115, 117 and 118. This should probably be fixed. This may a bit tricky because the key names in the strings file will need to change too, which could cause incompatibility with previous translations.

@SaurabhTotey
Copy link
Member

After working on this issue with @chrisklus and @jbphet, it seems like this issue is over. The keys in the shred-strings_en.json file were updated as per the suggestion of @jbphet. This means that certain translation files in babel have translations that won't actually get used (eg there is a translation defined for ununoctium, but no sim will ever ask for ununoctium because the new key is oganesson), but that should be fine, as those translations weren't in use anyways before. The new keys also apparently don't show up in Rosetta, but @jbphet said that that shouldn't be an issue for right now for the same reason. It seems like BAA and IAAM still work fine despite the new changes.

@SaurabhTotey SaurabhTotey removed their assignment Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants