Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComboBoxButton should extend RectangularButtonView #446

Closed
pixelzoom opened this issue Jan 15, 2019 · 4 comments
Closed

ComboBoxButton should extend RectangularButtonView #446

pixelzoom opened this issue Jan 15, 2019 · 4 comments
Assignees
@zepumph
Labels
dev:phet-io status:blocks-publication

Comments

@pixelzoom
Copy link
Contributor

More work that was not completed in #430.

ComboBoxButton should be a subclass of RectangularButtonView, in order to get all of the a11y and PhET-iO instrumentation that comes with sun buttons. It's currently a subclass of Node, so it requires special instrumentation.

It will probably require buttonAppearanceStrategy: RectangularButtonView.FlatAppearanceStrategy.

Assigning to @ariel-phet to prioritize and assign.
pixelzoom added a commit that referenced this issue Jan 15, 2019
@pixelzoom
TODO #446
046cc93
@pixelzoom
Copy link
Contributor Author

After sleeping on it, I think I'll take a stab at this.

@pixelzoom pixelzoom assigned pixelzoom and unassigned ariel-phet Jan 15, 2019
@zepumph zepumph mentioned this issue Jan 15, 2019
Closed
@pixelzoom
Copy link
Contributor Author

Making ComboBoxButton extend RectangularButtonView was easy. Working out the a11y changes was not. I worked on this with @zepumph, and we got most of the way there. See "TODO sun#314" and "TODO sun#447" in the code for remaining work.

pixelzoom added a commit that referenced this issue Jan 15, 2019
@pixelzoom
ComboBoxButton extends RectangularPushButton, #446
deaae9d
@pixelzoom
Copy link
Contributor Author

@zepumph is going to take it from here.

@pixelzoom pixelzoom assigned zepumph and unassigned pixelzoom Jan 15, 2019
@pixelzoom pixelzoom mentioned this issue Jan 15, 2019
Closed
@jessegreenberg jessegreenberg mentioned this issue Jan 16, 2019
Closed
@pixelzoom
Copy link
Contributor Author

This is done, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:phet-io status:blocks-publication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @ariel-phet @zepumph