Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog: Assertion failed: This node is already managed by a layout container #761

Closed
zepumph opened this issue May 26, 2022 · 2 comments
Closed

Comments

@zepumph
Copy link
Member

zepumph commented May 26, 2022

This is a new assertion added from layout changes by @jonathanolson. Full assertion:

Assertion failed: This node is already managed by a layout container - make sure to wrap it in a Node if DAG, removing it from an old layout container, etc

Here is the failing line of code:

children: options.title ? [ options.title, content ] : [ content ],

We should just be able to dispose this VBox to accomplish the bug fix.

To reproduce the bug, go to the state wrapper in ratio and proportion, and open the keyboard help dialog. Upon 2 set states, it will fail.

zepumph added a commit that referenced this issue May 26, 2022
@zepumph
Copy link
Member Author

zepumph commented May 26, 2022

This fixed the error in my testing. I'll wait to close until I confirm on CT.

@zepumph
Copy link
Member Author

zepumph commented May 26, 2022

The above issues are in fact this problem, just a downstream error from this assertion. When the DAG assertion triggers, it doesn't dispose the close button, so it recreates it again after startup and fails the phet-io API checker.

@zepumph zepumph closed this as completed Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant