Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GroupItemOptions for ToggleNode #798

Closed
samreid opened this issue Oct 8, 2022 · 1 comment
Closed

Use GroupItemOptions for ToggleNode #798

samreid opened this issue Oct 8, 2022 · 1 comment
Assignees
@samreid

Comments

@samreid
Copy link
Member

samreid commented Oct 8, 2022

Like #797 but for ToggleNode
@samreid samreid self-assigned this Oct 8, 2022
This was referenced Oct 10, 2022
Closed
Closed
samreid added a commit to phetsims/beers-law-lab that referenced this issue Oct 11, 2022
@samreid
Use GroupItemOptions for ToggleNode, see phetsims/sun#798
fd7d1b4
samreid added a commit that referenced this issue Oct 11, 2022
@samreid
Use GroupItemOptions for ToggleNode, see #798
ee7c87f
samreid added a commit to phetsims/geometric-optics that referenced this issue Oct 11, 2022
@samreid
Use GroupItemOptions for ToggleNode, see phetsims/sun#798
3d300d5
samreid added a commit to phetsims/gas-properties that referenced this issue Oct 11, 2022
@samreid
Use GroupItemOptions for ToggleNode, see phetsims/sun#798
9c6e1c9
samreid added a commit to phetsims/models-of-the-hydrogen-atom that referenced this issue Oct 11, 2022
@samreid
Use GroupItemOptions for ToggleNode, see phetsims/sun#798
f21ccb8
samreid added a commit to phetsims/joist that referenced this issue Oct 11, 2022
@samreid
Use GroupItemOptions for ToggleNode, see phetsims/sun#798
e071822
samreid added a commit to phetsims/wave-interference that referenced this issue Oct 11, 2022
@samreid
Use GroupItemOptions for ToggleNode, see phetsims/sun#798
c841cd9
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Oct 11, 2022
@samreid
Use GroupItemOptions for ToggleNode, see phetsims/sun#798
1320eab
@samreid
Copy link
Member Author

samreid commented Oct 11, 2022

Fixed, and noting that I'm leaving some occurrences like createNode => myNodeIAlreadyCreated as future sim-specific work that can be accomplished when that sim is instrumented. Closing.

@samreid samreid closed this as completed Oct 11, 2022
@samreid samreid mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samreid