Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TandemEmitter behavior to Emitter (if possible) #18

Closed
samreid opened this issue Feb 6, 2017 · 3 comments
Closed

Move TandemEmitter behavior to Emitter (if possible) #18

samreid opened this issue Feb 6, 2017 · 3 comments
Assignees
@zepumph
Labels
dev:phet-io priority:2-high status:ready-for-review

Comments

@samreid
Copy link
Member

samreid commented Feb 6, 2017

We would like to integrate tandem into all core classes, including Emitter. It may not be possible for Emitter, since Emitter may need to include child Emitters as part of its definition. We'll have to see.

See https://github.com/phetsims/phet-io/issues/926
This was referenced Feb 6, 2017
Closed
Closed
@samreid samreid self-assigned this Feb 6, 2017
samreid added a commit to phetsims/circuit-construction-kit-common that referenced this issue Aug 5, 2017
@samreid
Moved phet-io instrumentation to Emitter.js, see phetsims/tandem#18
3c1e043
samreid added a commit to phetsims/energy-skate-park-basics that referenced this issue Aug 5, 2017
@samreid
Moved phet-io instrumentation to Emitter.js, see phetsims/tandem#18
8aba7d9
samreid added a commit to phetsims/forces-and-motion-basics that referenced this issue Aug 5, 2017
@samreid
Moved phet-io instrumentation to Emitter.js, see phetsims/tandem#18
0699d02
samreid added a commit to phetsims/john-travoltage that referenced this issue Aug 5, 2017
@samreid
Moved phet-io instrumentation to Emitter.js, see phetsims/tandem#18
e2776b8
samreid added a commit to phetsims/build-an-atom that referenced this issue Aug 5, 2017
@samreid
Moved phet-io instrumentation to Emitter.js, see phetsims/tandem#18
cb249c1
samreid added a commit to phetsims/chipper that referenced this issue Aug 5, 2017
@samreid
Moved phet-io instrumentation to Emitter.js, see phetsims/tandem#18
e51088b
samreid added a commit that referenced this issue Aug 5, 2017
@samreid
Moved phet-io instrumentation to Emitter.js, see #18
a1530b7
samreid added a commit to phetsims/joist that referenced this issue Aug 5, 2017
@samreid
Moved phet-io instrumentation to Emitter.js, see phetsims/tandem#18
624f2d5
samreid added a commit to phetsims/shred that referenced this issue Aug 5, 2017
@samreid
Moved phet-io instrumentation to Emitter.js, see phetsims/tandem#18
a1e82ce
samreid added a commit to phetsims/axon that referenced this issue Aug 5, 2017
@samreid
Moved phet-io instrumentation to Emitter.js, see phetsims/tandem#18
6a2643d
samreid added a commit to phetsims/sun that referenced this issue Aug 5, 2017
@samreid
Moved phet-io instrumentation to Emitter.js, see phetsims/tandem#18
fafc58f
@samreid
Copy link
Member Author

samreid commented Aug 5, 2017

In the preceding commits @zepumph and I got things working. I'll leave this open and assigned to myself to double check on Bayes after the change, and assigned to @zepumph to double check the changes and see if there's anything else.

@samreid
Copy link
Member Author

samreid commented Aug 5, 2017

Bayes seems OK, @zepumph can you please double check everything?

@samreid samreid removed their assignment Aug 5, 2017
@zepumph
Copy link
Member

zepumph commented Aug 7, 2017

I think everything looks good to me. Thanks for finishing that up. Closing

@zepumph zepumph closed this as completed Aug 7, 2017
@jessegreenberg jessegreenberg mentioned this issue Aug 7, 2017
Closed
zepumph pushed a commit that referenced this issue Oct 19, 2018
@samreid @zepumph
Moved phet-io instrumentation to Emitter.js, see #18
9714e06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:phet-io priority:2-high status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph