Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace LevelSelectionItemNode with LevelSelectionButton #68

Closed
11 tasks done
pixelzoom opened this issue Apr 16, 2018 · 5 comments
Closed
11 tasks done

replace LevelSelectionItemNode with LevelSelectionButton #68

pixelzoom opened this issue Apr 16, 2018 · 5 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 16, 2018

LevelSelectionItemNode is deprecated per #59. It should be replaced by LevelSelectionButton in the sims listed below. This is not a straightforward conversion, since the API has changed significantly to support new features requested by designers.

Last person to convert a sim:

  • delete LevelSelectionItemNode
@pixelzoom pixelzoom self-assigned this Apr 16, 2018
pixelzoom added a commit to phetsims/balancing-chemical-equations that referenced this issue Apr 16, 2018
pixelzoom added a commit to phetsims/graphing-lines that referenced this issue Apr 16, 2018
pixelzoom added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Apr 16, 2018
@pixelzoom
Copy link
Contributor Author

My sims have been converted to LevelSelectionButton.

Assigning this to other developers who are responsible for sims in the check list above.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 16, 2018

By the way... One of the things that made this very easy to test for my sims was the ?showAnswers query parameter that I've implemented for all games. If other sims had this, I might have converted some of the sims that I'm not responsible for. Without, it's just too much time.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 19, 2018

Labeled for developer meeting to make developers aware of this, and confirm with @ariel-phet that this is properly labeled as "chip away".

And do we want to create an issue for each sim, or handle this here? An issue for each sim probably has a better chance of getting seen/addressed when it's time to revisit the sim.

jbphet added a commit to phetsims/area-builder that referenced this issue Apr 20, 2018
jbphet added a commit to phetsims/arithmetic that referenced this issue Apr 20, 2018
jbphet added a commit to phetsims/balancing-act that referenced this issue Apr 20, 2018
jbphet added a commit to phetsims/build-an-atom that referenced this issue Apr 24, 2018
jbphet added a commit to phetsims/expression-exchange that referenced this issue Apr 24, 2018
@jbphet
Copy link
Contributor

jbphet commented Apr 24, 2018

I have converted all sims for which I and the responsible developer.

@jonathanolson
Copy link
Contributor

Refactored out usages, deleted. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants