Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite GameAudioPlayer to use tambo #77

Closed
jbphet opened this issue Apr 22, 2019 · 18 comments
Closed

Rewrite GameAudioPlayer to use tambo #77

jbphet opened this issue Apr 22, 2019 · 18 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Apr 22, 2019

The GameAudioPlayer type currently uses the older vibe library and should be rewritten to use tambo instead, since that library uses Web Audio in a more standard way and is the one we plan to use long term.

@jbphet jbphet self-assigned this Apr 22, 2019
@jbphet
Copy link
Contributor Author

jbphet commented Apr 22, 2019

Closely related to phetsims/vibe#33.

@jbphet
Copy link
Contributor Author

jbphet commented Jun 4, 2019

Here is a list of the sims that will need to have sound buttons removed and be tested for this change:

  • arithmetic
  • build-a-molecule
  • make-a-ten
  • build-a-fraction
  • area-builder
  • balancing-act
  • build-an-atom
  • fraction-matcher
  • fractions-equality
  • fractions-intro
  • fractions-mixed-numbers
  • area-model-algebra
  • area-model-multiplication
  • equality-explorer
  • expression-exchange
  • graphing-lines
  • balancing-chemical-equations
  • reactants-products-and-leftovers

jbphet added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/balancing-chemical-equations that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/expression-exchange that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/equality-explorer that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/build-a-molecule that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/graphing-lines that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/balancing-act that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/build-an-atom that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/area-builder that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/make-a-ten that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/arithmetic that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/area-model-common that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/fractions-common that referenced this issue Jun 4, 2019
jonathanolson added a commit to phetsims/area-model-algebra that referenced this issue Jun 4, 2019
jonathanolson added a commit to phetsims/area-model-common that referenced this issue Jun 4, 2019
jonathanolson added a commit to phetsims/area-model-multiplication that referenced this issue Jun 4, 2019
jonathanolson added a commit to phetsims/build-a-fraction that referenced this issue Jun 4, 2019
jonathanolson added a commit to phetsims/fraction-matcher that referenced this issue Jun 4, 2019
jonathanolson added a commit to phetsims/fractions-equality that referenced this issue Jun 4, 2019
jonathanolson added a commit to phetsims/fractions-intro that referenced this issue Jun 4, 2019
jonathanolson added a commit to phetsims/fractions-mixed-numbers that referenced this issue Jun 4, 2019
jonathanolson added a commit to phetsims/make-a-ten that referenced this issue Jun 4, 2019
jonathanolson added a commit to phetsims/build-a-molecule that referenced this issue Jun 4, 2019
jbphet added a commit to phetsims/arithmetic that referenced this issue Jun 4, 2019
@pixelzoom
Copy link
Contributor

pixelzoom commented Nov 15, 2021

I recommend this option, to be applied to all sims that use GameAudioPlayer and have not been explicitly released with UI sounds enabled:

  • (D) Do something to enable game sounds, but not all UI sounds. (The correct way to address this issue, imo.)

This can be accomplished by setting the output level to zero for the 'ui-sounds' category:

soundManager.setOutputLevelForCategory( 'user-interface', 0 );

But this exposes another bug. Sounds that were recently added to vegas UI components (LevelSelectionButton, back button in scoreboard, ...). were not associated with the 'ui-sounds' category, so can't be turned off. This will also need to be fixed in #98.

@kathy-phet
Copy link

@jbphet and @markgammon will collaborate on a sim-specific issue, and put individual issues in the repos of the sims with effected games.

@pixelzoom
Copy link
Contributor

pixelzoom commented Nov 18, 2021

11/18/21 design meeting: @amanda-phet @arouinfar @kathy-phet @markgammon @jbphet @chrisklus @ariel-phet

@markgammon
Copy link

@pixelzoom - @jbphet and I created an issue for deciding whether to turn off UI sounds and have added it to each of the listed sims.

Should this issue remain open or ok to close?

@jbphet jbphet removed their assignment Nov 19, 2021
@pixelzoom
Copy link
Contributor

Sorry I missed the above question - this issue was not assigned back to me.

OK to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants