-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite GameAudioPlayer to use tambo #77
Comments
Closely related to phetsims/vibe#33. |
Here is a list of the sims that will need to have sound buttons removed and be tested for this change:
|
I recommend this option, to be applied to all sims that use GameAudioPlayer and have not been explicitly released with UI sounds enabled:
This can be accomplished by setting the output level to zero for the 'ui-sounds' category:
But this exposes another bug. Sounds that were recently added to vegas UI components (LevelSelectionButton, back button in scoreboard, ...). were not associated with the 'ui-sounds' category, so can't be turned off. This will also need to be fixed in #98. |
@jbphet and @markgammon will collaborate on a sim-specific issue, and put individual issues in the repos of the sims with effected games. |
11/18/21 design meeting: @amanda-phet @arouinfar @kathy-phet @markgammon @jbphet @chrisklus @ariel-phet
|
Issues created indicating UI sounds have been enabled and how to turn these off: |
@pixelzoom - @jbphet and I created an issue for deciding whether to turn off UI sounds and have added it to each of the listed sims. Should this issue remain open or ok to close? |
Sorry I missed the above question - this issue was not assigned back to me. OK to close. |
The
GameAudioPlayer
type currently uses the oldervibe
library and should be rewritten to usetambo
instead, since that library uses Web Audio in a more standard way and is the one we plan to use long term.The text was updated successfully, but these errors were encountered: