Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リファクタ #3

Merged
merged 1 commit into from
Sep 27, 2019
Merged

リファクタ #3

merged 1 commit into from
Sep 27, 2019

Conversation

simiraaaa
Copy link
Collaborator

start(false)のあとにstart(true)するケースがありましたが、2回イベントハンドラが設定されるため、startは1度まで実行にして、それ以降 start(true)とおなじ挙動にしたい場合は exec を実行するようにしました

@phi-jp
Copy link
Owner

phi-jp commented Sep 27, 2019

@simiraaaa LGTM

@phi-jp phi-jp merged commit 00e5bc3 into develop Sep 27, 2019
@phi-jp phi-jp deleted the feature/refactor branch September 27, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants