New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

body 全体がスクロールしたときもイベント発火させられるよう対応 #3

Merged

phi-jp merged 3 commits into develop from feature/scroll_body

Dec 4, 2020

Owner

phi-jp commented Dec 3, 2020 •

edited

Loading

確認方法

npm run dev
http://127.0.0.1:8080/test/scroll-body.html にアクセス
スクロールすると追加ロードされるのを確認

memo

body は onscroll は動くが, addEventListener('scroll' は動かない
document は onscroll は動かないが, addEventListener('scroll' は動く

phi-jp added 3 commits

December 3, 2020 19:29


          body 全体がスクロールしたときもイベント発火させられるよう対応

22a5af6

fix

26d2e14


          fix test

d3e9cbf

Collaborator

simiraaaa commented Dec 3, 2020

LGTM

kasaji-jp commented Dec 4, 2020

動作LGTM
コードはゆっくり勉強させてもらいます

phi-jp merged commit 724dc77 into develop

phi-jp deleted the feature/scroll_body branch

December 4, 2020 05:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet