Start adding tests. #1010
Merged
Start adding tests. #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow this adresses #23 so we could start closing that too. |
isometriks
force-pushed
the
add-xpath-tests
branch
from
d6a3dd3
to
4f028e0
Compare
isometriks
added a commit
that referenced
this pull request
Jan 13, 2015
Add some basic unit tests and an abstract class that allows to easily test output of forms. Updated travis and composer to build properly.
Closed
|
perfect! THNX a lot dude |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works similarly to how Symfony is doing it. It will render the form element and then use XPath to make sure it is rendered correctly. I made an abstract base class so each extension can be overridden to test to make sure the options work.