-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeTestCase #956
TypeTestCase #956
Conversation
protected function getTypeExtensions() | ||
{ | ||
return [ | ||
new MopaExtensions\WidgetCollectionFormTypeExtension([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pass a default configuration to Extensions, but maybe we should inject a container and get an information from it? This will make tests a bit slower, but support of configuration. @phiamo what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having the conf available would make it easier, and tests can be written ob a per project basis too.
can you add an example test using this, to sandboixbundle and a new doc describing the purpuse please!
this is awesome!
621196f
to
3c6f3d8
Compare
@phiamo Done. I added a configuration support and a documentation. |
This is cool, thank you. I was always thinking about adding something that rendered the actual forms in Twig and either using the DomCrawler to check for certain structure / classes or to actual write out the html and ignore whitespace to see if they were the same |
29c9954
to
6708dba
Compare
ping @phiamo |
34c5c19
to
4ec1e08
Compare
4ec1e08
to
865348a
Compare
thanks a lot! |
Hey. I prepared a
TypeTestCase
class with support of a MopaBootstrapBundle form extensions. It will allow users to write a unit tests for a forms which uses MopaBootstrap form types.