TopBar strings not truncated correctly by auto-width (to krypton) #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For non-concatenated topbar strings each part of the string is truncated seperately by auto-width resulting in incorrect truncation. Also auto width not working unless the width is specified. Solution - create vars to concatenate topbar strings prior to auto-width truncation and specify width value for auto-width.
linknetx
changed the title
|
Here is an example: Before: After: |
|
This fixes the problem so is it possible to merge it ? |
phil65
reviewed
Oct 11, 2017
| <value>$LOCALIZE[1213] / $INFO[Container.FolderName]</value> | ||
| </variable> | ||
| <variable name="BreadcrumbsMusicVar"> | ||
| <value>$LOCALIZE[2] / $INFO[Container.FolderName]</value> |
There was a problem hiding this comment.
Why putting single values into a var?
|
I learned yesterday that this repository is unmaintained and you need to propose this change to the upstream https://github.com/xbmc/xbmc repository. Good luck ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-concatenated topbar strings each part of the string is truncated
seperately by auto-width resulting in incorrect truncation.
Also auto-width not working unless the width is specified.
Solution - create vars to concatenate topbar strings prior to auto-width
truncation and specify width value for auto-width.