WaveRecorder: fix hang in StreamingThread #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The read() could hang forever waiting for data when the WaveRecorder was stopped. Now it terminates the thread. Fixes #105
zstojanovic
reviewed
Jan 30, 2022
| buffer[i + start] = read(); | ||
| numRead++; | ||
| } | ||
| } else { | ||
| if (available() < count) { | ||
| count = available(); |
There was a problem hiding this comment.
I know you didn't ask for a PR review, but count is set here and never read.
Maybe this should be:
numRead = available();
There was a problem hiding this comment.
Thanks. I'm looking at this code and see another bug when (available() < count). It does not read any data.
I added a test for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read() could hang forever waiting for data when the
WaveRecorder was stopped.
Now it terminates the thread.
Fixes #105