Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vimium-FF 1.63 'f' button triggers pop-ups blocker and 'F' button do not work #2958

Closed
chutaklee opened this issue Feb 17, 2018 · 4 comments
Closed

Vimium-FF 1.63 'f' button triggers pop-ups blocker and 'F' button do not work #2958

chutaklee opened this issue Feb 17, 2018 · 4 comments

Comments

@chutaklee
Copy link

chutaklee commented Feb 17, 2018 •
edited
Loading

Version: Vimium-FF 1.63 from Firefox addons store (most recent)
Firefox: 58.0.2 (64 bit)

Current Behavior
Using f button triggers firefox pop-ups blocker
After using F button, no new tab show up
rolling back to Vimium-FF version 1.62.8 fix these problems

Expected Behavior
Using f button should open the link
Using F button should open the link in new tab
@troglotit
Copy link

It seems like this commit changed behavior. F and f works as expected on anchors without target='_blank'.
But on target='_blank' on 1.62 f used to open two links (right know it works as expected) but F doesn't open links at all (but used to work as expected)

@zhenjieliang
Copy link

This problem drives me crazy. At first I doubt it was caused by my editing of .vimrc, after deleting my .vimrc, the problem is not solved. then I tried to reinstall the vimium-ff addon, nothing goes well. Now I use surfingkeys addon.

smblott-github added a commit to smblott-github/vimium that referenced this issue Feb 18, 2018
@smblott-github
Fix Firefox link hints.
d9f7989 
Fixes philc#2958 (probably).

This appears to be correct for target "_blank" (or not) and modifiers
(or not).  That's four cases.

It will be *incorrect* if there is a click listener on a target "_blank"
link.  Some conditions are tested to try to prevent that from happening.

This only affects Firefox.  Chrome is unaffected.
@smblott-github smblott-github mentioned this issue Feb 18, 2018
Merged
@smblott-github
Copy link
Collaborator

I think #2960 is the fix for this, and I'd like to merge and push it as v1.63.1 ASAP.

However, I'm not a FF user myself, and some feedback from somebody more familiar with FF would be helpful first.

@smblott-github
Copy link
Collaborator

v1.63.1 is now at AMO, it will be reviewed and published soon.

You can check your version on the popup page...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smblott-github @chutaklee @troglotit @zhenjieliang