feat(completion): adds man page search, completion #4091
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am a big fan of this project and humbly request this PR for consideration.
It adds support for man page completion by way of mankier. This site is very useful for reading command documentation in the browser. Here is an example of such a man page.
BaseEngine
.Small refactor to use Fetch instead of
XMLHttpRequest
. I did this for two reasons:Fetch
, as SW has no access toXMLHttpRequest
.XMLHttpRequest
has no equivalent of mode - without which API calls to the ManKier endpoint will fail, due to a CSP violation.Thank you!
Please review the "Which pull requests get merged?" section in
CONTRIBUTING.md
.✅