Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RuneScape Wiki and OldSchool RuneScape Wiki #4238

Closed
wants to merge 1 commit into from

Conversation

Ivy-Panda
Copy link

@philc
Copy link
Owner

philc commented Jul 21, 2023

Thanks @Ivy-Panda for the submission!

I think this is too niche to live in the main repo -- I don't use the Runescape wiki and don't want to maintain the parsing code).

I haven't figured out a way to make search engine completions easily extensible with user-code for more niche search engines.

@philc philc closed this Jul 21, 2023
@rileywilddog
Copy link
Contributor

rileywilddog commented Jul 21, 2023

JSON.parse(xhr.responseText)[1] doesn't seem like a particularly onerous maintenance burden, and this seems like the search suggestion response format basically everything (including google) supports now...

Edit: Ah, you're even aware of this... 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants