Fix find mode not searching inside elements with display property set to contents
#4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rty set to `contents` made the find mode dom node traversal algorithms search for visible nodes inside elements with display property set as contents. This had to be done because the `checkVisibility` method considers these elements as not visible, however the children of these elements are visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4492.
The
checkVisibilitymethod considers elements withdisplayset tocontentsas not visible in the page and it is true that the element is not visible, but its children are completely visible. So I simply made the node traversal algorithm also visit the children of elements withnode.style.display === 'contents'and it worked.