Remove bashisms from get_latest_dumps.sh #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why first line is currently just a `#`, but for this to be launchable it ought to be a shebang (`#!`). https://en.wikipedia.org/wiki/Shebang_(Unix)
This script is not that complicated and doesn’t use a lot of the features of bash, so in case people want to run this using dash (for lower overhead) or any other POSIX compliant shell, changing the bashisms in this script allow them to do just this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script is not that complicated and doesn’t use a lot of the features of bash, so in case people want to run this using dash (for lower overhead) or any other POSIX compliant shell, changing the bashisms in this script allow them to do just this.