Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript Definitions #19

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

nataly87s
Copy link
Contributor

following issue #12

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #19   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          53     53           
  Branches       12     12           
=====================================
  Hits           53     53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e24bda...3ee3b2f. Read the comment docs.

Copy link
Owner

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you so much!

I'd like to also add some tests for the typescript declarations, much like in the Immutable.js repo. Do you want to take a look here as well? No pressure though 🙂

I think we also need to make some changes to the build system so that the type definitions are properly exposed - I'm not sure what's the best way to do this though. I'd again take a look at the Immutable.js repo 🙈

@philipp-spiess philipp-spiess merged commit 7adcfa1 into philipp-spiess:master Oct 11, 2018
@nataly87s nataly87s deleted the typescript-support branch October 13, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants