-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NewEmbeddingFuncOllamaWithURL #64
Add NewEmbeddingFuncOllamaWithURL #64
Conversation
Allows the user to specify the base URL of Ollama instead of the default localhost one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you very much for submitting the PR 👍
I would even be open to a breaking change and just add the URL param to the existing constructor function, but no strong preference. WDYT?
Agreed, the warning in the readme is enough to allow for this. I have changed it. |
I added a small update to the example that uses the Ollama function. It didn't show up in the GitHub Action build because the build pipeline is missing a compile for the examples - added it to my TODOs. Thanks again! |
Done in #66 |
@philippgille would it be possible to tag a new version? |
Is it okay to wait for #63, or is it urgent (as in you're building a project with chromem and would like to have this update right now)? |
No problem, I can wait for that. |
That's merged now, I'll cut a release in the next days, maybe I can squeeze some other changes before |
Released v0.6.0: https://github.com/philippgille/chromem-go/releases/tag/v0.6.0 |
Allows the user to specify the base URL of Ollama instead of the default localhost one.