-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies of all modules #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Fix test.sh script for CockroachDB container
Including a config change in the test Docker container for concurrency
Also changed the test code to work without shared config/credentials file
Required a change of the client code because of breaking changes between v0 and v1
+ Use default port in test container, since we won't run in TravisCI anymore
Tested with real Azure, because it still doesn't work with the emulator.
philippgille
force-pushed
the
upgrade-dependencies
branch
from
May 26, 2022 19:30
2658376
to
da19819
Compare
philippgille
force-pushed
the
upgrade-dependencies
branch
from
May 26, 2022 19:32
da19819
to
b76f564
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the dependencies of all modules within the same major version, except for one v0 -> v1 change (which is in line with regular
go get
behavior).The v0 -> v1 change was for Hazelcast, for which some code changes were required to make it work with the latest version. To
gokv
users there should be no difference in behavior, so no breaking change.Another noteworthy change is that we're now independent from any CI environment. In the past the tests still relied on some servers being provided by Travis CI (namely Memcached, MongoDB, MySQL and Redis), but the test script now starts Docker containers them as well.
All tests succeed (
build/test.sh
plus separate run withtablestorage
module against real Azure because of issues with the emulator) 🟢