Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add more go versions for compatibility testing #134

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

glimchb
Copy link
Contributor

@glimchb glimchb commented Oct 23, 2023

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb closed this Oct 23, 2023
@glimchb glimchb reopened this Oct 23, 2023
@glimchb glimchb closed this Oct 26, 2023
@glimchb glimchb reopened this Oct 26, 2023
Copy link
Owner

@philippgille philippgille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Actually I think we should even remove the old Go versions, as they're not supported by the Go team anymore (i.e. not even getting security fixes anymore) so shouldn't be used by anyone. And even if some do, I think for us as maintainers of an open source library it's sensible to reduce the number of supported versions to the officially supported ones.
We can still be nice and not use the latest language features or stdlib additions, so older versions should still work, but we don't provide any guarantees.

But that can follow later as well, I'm just merging this for now.

@philippgille philippgille merged commit 099e3a0 into philippgille:master Oct 31, 2023
7 of 17 checks passed
@glimchb glimchb deleted the ci-go-ver branch October 31, 2023 15:15
@glimchb
Copy link
Contributor Author

glimchb commented Oct 31, 2023

Actually I think we should even remove the old Go versions, as they're not supported by the Go team anymore (i.e. not even getting security fixes anymore) so shouldn't be used by anyone. And even if some do, I think for us as maintainers of an open source library it's sensible to reduce the number of supported versions to the officially supported ones. We can still be nice and not use the latest language features or stdlib additions, so older versions should still work, but we don't provide any guarantees.

absolutely agree 100%
I left this for your discretion when exactly to retire old go versions.
we should also bump version in go.mod files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants