Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace interface{} with any #150

Merged
merged 4 commits into from
Dec 3, 2023
Merged

Conversation

philippgille
Copy link
Owner

@philippgille philippgille commented Nov 26, 2023

Introduced in Go 1.18

Many popular Go projects did this already, like Tailscale here: tailscale/tailscale#4189

If any user is stuck on Go older than 1.18 and would like to use gokv, please open an issue - we can discuss reverting this change.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (68e55ce) 65.26% compared to head (822e5c5) 65.26%.

Files Patch % Lines
tablestorage/tablestorage.go 0.00% 3 Missing ⚠️
mongodb/mongodb.go 0.00% 2 Missing ⚠️
tablestore/tablestore.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   65.26%   65.26%           
=======================================
  Files          25       25           
  Lines        2096     2096           
=======================================
  Hits         1368     1368           
  Misses        601      601           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippgille philippgille merged commit f23c262 into master Dec 3, 2023
8 checks passed
@philippgille philippgille deleted the replace-interface-with-any branch January 7, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants