Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BigCache from v2 to v3 #158

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

philippgille
Copy link
Owner

Version 2 is not maintained anymore, and there are not many changes to v3, so we can update without breaking anything on our side: allegro/bigcache@v2.2.5...v3.1.0

In fact, this update fixes a concurrency issue that was probably coming from BigCache side. Running go test -v -race -count 100 -run TestStoreConcurrent . previously lead to one of the runs to have issues, but that seems to be solved.
We actually run into this in CI fairly often (e.g. latest one here), so it's really useful to have this fixed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ff6a17) 65.26% compared to head (ef67ed6) 65.26%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   65.26%   65.26%           
=======================================
  Files          25       25           
  Lines        2096     2096           
=======================================
  Hits         1368     1368           
  Misses        601      601           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippgille philippgille merged commit b267a13 into master Dec 5, 2023
8 checks passed
@philippgille philippgille deleted the update-bigcache-from-v2-to-v3 branch January 7, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants