Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate MongoDB client from unmaintained 3rd party library to official one #165

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

philippgille
Copy link
Owner

@philippgille philippgille commented Jan 2, 2024

When gokv was started, the 3rd-party library github.com/globalsign/mgo was the most popular and mature MongoDB client library for Go. But that changed and the official library go.mongodb.org/mongo-driver is now the proper go-to library. mgo is not maintained anymore and seems to not be compatible with newer versions of the MongoDB server anymore.

This PR updates the MongoDB library from github.com/globalsign/mgo to go.mongodb.org/mongo-driver.

I haven't tested the new gokv implementation with an older MongoDB server version (where mgo still worked), but from the way of how the document is defined, inserted/updated, read and deleted it could be compatible.

I'll add a breaking change notice to the CHANGELOG as a warning in any case. (separately)

…l one

From github.com/globalsign/mgo to go.mongodb.org/mongo-driver
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e6beda) 60.56% compared to head (6f1def7) 63.64%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   60.56%   63.64%   +3.08%     
==========================================
  Files          25       25              
  Lines        2097     2107      +10     
==========================================
+ Hits         1270     1341      +71     
+ Misses        716      651      -65     
- Partials      111      115       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippgille philippgille marked this pull request as ready for review January 7, 2024 15:19
@philippgille philippgille merged commit 1529928 into master Jan 7, 2024
8 checks passed
@philippgille philippgille deleted the update-mongodb-client branch January 7, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants