-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable http connection #63
Add configurable http connection #63
Conversation
Nice job! Could you please add a test for NewHTTPConnection? |
As it is only used in tests, I don't bother :-) |
Maybe I'm doing this wrong- how would you connect to the API above instead? |
No, no, you are doing perfectly right. I meant removing the existing NewHTTPClient doesn't bother me. |
@philippseith do you want to start CI? |
6f3a870
to
b85701f
Compare
Tests are updated, too and http client removed |
Fix #60
By passing e.g. an oauth2 client, the http connection connection can securely connect.
Example:
I would also suggest to remove the
NewHTTPClient
as it has only limited flexibility (breaking change).