Add some missing defer calls to Close

Signed-off-by: Marco Franssen <marco.franssen@philips.com>
philips-labs · Dec 1, 2021 · 6a59561 · 6a59561
1 parent 75cb706
commit 6a59561
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/cmd/slsa-provenance/cli/github-release_test.go b/cmd/slsa-provenance/cli/github-release_test.go
@@ -86,6 +86,7 @@ func createGitHubRelease(ctx context.Context, client *github.ReleaseClient, owne
 		if err != nil {
 			return 0, err
 		}
+		defer asset.Close()
 		client.AddProvenanceToRelease(ctx, owner, repo, rel.GetID(), asset)
 	}
 

diff --git a/lib/github/provenance.go b/lib/github/provenance.go
@@ -133,6 +133,7 @@ func (e *ReleaseEnvironment) PersistProvenanceStatement(ctx context.Context, stm
 	if err != nil {
 		return fmt.Errorf("failed to open provenance statement: %w", err)
 	}
+	defer stmtFile.Close()
 
 	owner := e.Context.RepositoryOwner
 	repo := repositoryName(e.Context.Repository)

diff --git a/lib/github/releases_test.go b/lib/github/releases_test.go
@@ -123,6 +123,7 @@ func TestAddProvenanceToRelease(t *testing.T) {
 	if !assert.NoError(err) || !assert.NotNil(provenance) {
 		return
 	}
+	defer provenance.Close()
 
 	stat, err := provenance.Stat()
 	if !assert.NoError(err) || !assert.NotNil(stat) {
@@ -212,6 +213,8 @@ func createGitHubRelease(ctx context.Context, client *github.ReleaseClient, owne
 		if err != nil {
 			return 0, err
 		}
+		defer asset.Close()
+
 		client.AddProvenanceToRelease(ctx, owner, repo, rel.GetID(), asset)
 	}