Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add annotations to manifest #201

Merged
merged 12 commits into from
Nov 10, 2023
Merged

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Nov 10, 2023

Add annotations to the manifest file as-per https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#adding-a-description-to-multi-arch-images.

Adding annotations has several benefits:

Adding annotations can be simplified when docker/build-push-action#992 is merged.

@rjaegers rjaegers requested a review from a team as a code owner November 10, 2023 08:32
Copy link
Contributor

github-actions bot commented Nov 10, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 11 0 0.04s
✅ DOCKERFILE hadolint 1 0 0.41s
✅ JSON eslint-plugin-jsonc 7 0 0 3.55s
✅ JSON prettier 7 0 0 0.58s
✅ JSON v8r 7 0 3.58s
✅ MARKDOWN markdownlint 3 0 0 0.92s
✅ MARKDOWN markdown-link-check 3 0 4.18s
✅ MARKDOWN markdown-table-formatter 3 0 0 0.29s
✅ REPOSITORY checkov yes no 15.65s
✅ REPOSITORY gitleaks yes no 0.3s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.61s
✅ REPOSITORY secretlint yes no 1.43s
✅ REPOSITORY trivy yes no 11.25s
✅ REPOSITORY trivy-sbom yes no 3.98s
✅ REPOSITORY trufflehog yes no 5.17s
✅ SPELL lychee 32 0 0.94s
✅ YAML prettier 13 0 0 0.9s
✅ YAML v8r 13 0 12.01s
✅ YAML yamllint 13 0 0.42s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Nov 10, 2023

Test Results

16 tests  ±0   16 ✔️ ±0   34s ⏱️ -18s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 678fcc1. ± Comparison against base commit 96157b1.

♻️ This comment has been updated with latest results.

@rjaegers rjaegers added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@rjaegers rjaegers added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@rjaegers rjaegers added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit 1afec52 Nov 10, 2023
14 checks passed
@rjaegers rjaegers deleted the feature/add-annotations-to-manifest branch November 10, 2023 14:29
Copy link
Contributor

Pull Request Report (#201)

Static measures

Description Value
Number of added lines 7
Number of deleted lines 1
Number of changed files 1
Number of commits 12
Number of reviews 1
Number of comments (w/o review comments) 2
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 3

Time related measures

Description Value
PR lead time (from creation to close of PR) 6 Hours
Time that was spend on the branch before the PR was created 1.5 Min
Time that was spend on the branch before the PR was merged 6 Hours
Time to merge after last review 2.7 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 9.7 Min
Total time spend in last status check run on PR 3.8 Min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants