Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with unmatched chunks #40

Closed
lionel- opened this issue Sep 7, 2015 · 5 comments
Closed

Bug with unmatched chunks #40

lionel- opened this issue Sep 7, 2015 · 5 comments

Comments

@lionel-
Copy link

lionel- commented Sep 7, 2015

It happens when two different types of blocks are used.

To reproduce, copy the following in a new .org file:

#+BEGIN_SRC clojure
(some-code)
#+END_SRC

#+BEGIN_SRC other-lang
example
#+END_SRC

# Local Variables:
# lentic-init: lentic-org-clojure-init
# End:

Then:

  • create a lentic buffer and switch to it
  • make a change in the buffer.

This results in the original creator buffer getting commented everywhere. It also does weird things to the undo history and it's not possible to get back to the original text.

@phillord
Copy link
Owner

phillord commented Sep 7, 2015

Thanks for the report, I've reproduced the behaviour now. Not sure of the cause yet, but will investigate when I can.

@phillord
Copy link
Owner

phillord commented Sep 9, 2015

Found the cause -- the "invert" function is wrong, so it's running an
unmatched transform in one direction and matched in the other.

Thinking about a solution, but it's not going to be immediate, I am
afraid.

Phil

Lionel Henry notifications@github.com writes:

It happens when two different types of blocks are used and we try to modify a "non-native" chunk.

To reproduce, copy the following in a new .org file:


#+BEGIN_SRC clojure
(some-code)
#+END_SRC

#+BEGIN_SRC other-lang
example
#+END_SRC


# Local Variables:
# lentic-init: lentic-org-clojure-init
# End:

Then:

  • create a lentic buffer and switch to it
  • make a change in the buffer.

This results in the original creator buffer getting commented everywhere. It
also does weird things to the undo history and it's not possible to get back
to the original text.


Reply to this email directly or view it on GitHub:
#40

@phillord
Copy link
Owner

This should be fixed now, I believe. The "weird things with the undo" should also be fixed also, but am afraid this required core emacs updates -- so it will only be on Emacs-25.

@lionel-
Copy link
Author

lionel- commented Dec 23, 2015

Thanks a lot Phil! I saw you struggle on emacs-devel with that undo thing ;) Glad it's worked out.

@phillord
Copy link
Owner

Took a bit longer than I expected, I have to admit, but I learned a lot and Stefan was tremendously helpful. Looks like master is still broken as a result, though! Oh dear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants