Add optional gofmt support
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes two type conversions.
I noticed in a different project that `gofumpt -w .` passes generated files through `gofmt`. This includes the mocks generated by ut. As the mocks generated by ut are not `gofmt`-formatted, the operations `go generate ./...` and `gofumpt -w .` do not commute. This commit adds an (optional) flag to the tool to indicate to the tool that mock files should be passed through `gofmt` before being written out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits: one to remove some type conversions, another that adds optional support for applying
gofmtto the generated mocks.The reason for the latter is that I noticed in a different project that
gofumpt -w .passes generated files throughgofmt. This includes the mocks generated by ut. As the mocks generated by ut are notgofmt-formatted, the operationsgo generate ./...andgofumpt -w .do not commute. This flag should ensure (if enabled) that they commute.