Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #16

Merged
merged 8 commits into from
Jun 27, 2020
Merged

Update deps #16

merged 8 commits into from
Jun 27, 2020

Conversation

ilyalatt
Copy link
Contributor

No description provided.

Copy link
Owner

@philpep philpep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for this. I left some review comments and I'd be happy to merge ASAP !

main.go Outdated Show resolved Hide resolved
@@ -1,8 +1,10 @@
module github.com/philpep/imago

go 1.16
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite new to go modules, what's the effect of this statement ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is autogenerated. Your project is my first experience with go language :) I guess it specifies runtime version. I guess it is needed in a such case: new major go runtime version is released, it is shipped with go along with the old runtime, by default go selects the new runtime which breaks old apps without go runtime version specified in go.mod.

github.com/containers/image/v5 v5.4.4
k8s.io/api v0.18.3
k8s.io/apimachinery v0.18.3
k8s.io/client-go v0.18.3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what command you typed to get these updated ? (go get or go get -u ?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced versions manually. https://github.com/kubernetes/api/releases

go.sum Show resolved Hide resolved
@ilyalatt
Copy link
Contributor Author

ilyalatt commented Jun 2, 2020

The reason why I decided to update deps is not just a wish but necessity for me :)
go get github.com/philpep/imago/... results in errors like

../../go/src/github.com/philpep/imago/main.go:146:58: not enough arguments in call to client.Deployments(c.namespace).List
	have ("k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions)
	want (context.Context, "k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions)

So it resolves latest k8s api instead of specified in go.mod. go build works fine however.

@philpep philpep merged commit e26864b into philpep:master Jun 27, 2020
@philpep
Copy link
Owner

philpep commented Jun 27, 2020

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants