-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps #16
Update deps #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for this. I left some review comments and I'd be happy to merge ASAP !
@@ -1,8 +1,10 @@ | |||
module github.com/philpep/imago | |||
|
|||
go 1.16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm quite new to go modules, what's the effect of this statement ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is autogenerated. Your project is my first experience with go language :) I guess it specifies runtime version. I guess it is needed in a such case: new major go runtime version is released, it is shipped with go along with the old runtime, by default go selects the new runtime which breaks old apps without go runtime version specified in go.mod.
github.com/containers/image/v5 v5.4.4 | ||
k8s.io/api v0.18.3 | ||
k8s.io/apimachinery v0.18.3 | ||
k8s.io/client-go v0.18.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what command you typed to get these updated ? (go get or go get -u ?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced versions manually. https://github.com/kubernetes/api/releases
The reason why I decided to update deps is not just a wish but necessity for me :)
So it resolves latest k8s api instead of specified in |
Merged, thanks! |
No description provided.