add Cask::SubversionDownloadStrategy #2822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abstract out module
Cask::DownloadStrategy
, add some commentaryThe interface is through new
url
keys::using
,:trust_cert
, and:revision
.There's one oddity about this implementation, which is that I tarball the directory that SVN gives us. At first glance this sounds like a horrible hack, but I've decided that it is actually a solid way to go. Here are my comments on the subject from the code:
And here is an example Cask that would use this functionality in the fonts repo, addressing Homebrew/homebrew-cask-fonts#29, where multiple Casks are required to supply a single font.