Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple repositories in same redmine project #36

Merged
merged 2 commits into from
Jan 15, 2018

Conversation

jcppkkk
Copy link
Contributor

@jcppkkk jcppkkk commented Nov 17, 2017

  • Create local repo with path like namespace/repo, mapping to gitlab.
  • One webhook triggers updating for single git repo instead of all repositories under the project.
  • Fix a bug that a repo does not get update after been created automatically.

@phlegx
Copy link
Owner

phlegx commented Jan 8, 2018

Hi @jcppkkk! Thank you for your pull request. Nice work!

Can you do the following please:

  1. Change all params['xxxxx'] to params[:xxxxx] if possible?
  2. We use unless instead of if not now. Line 134.
  3. Line 92 change "" to ''

Then we will merge your pull request. Thx! 😃

@phlegx
Copy link
Owner

phlegx commented Jan 15, 2018

Hi @jcppkkk! Thank you so much! 👍 👍 👍

@phlegx phlegx merged commit dd60f35 into phlegx:master Jan 15, 2018
@phlegx
Copy link
Owner

phlegx commented May 16, 2018

@jcppkkk can you please add examples how you use the hook with multiple repositories in same redmine project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants