This repository has been archived by the owner on Jan 23, 2019. It is now read-only.
Fix converge error caused by overwriting runnig bin file #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@fulloflilies thank you very much for this! I have fixed up the test failures and merged this in as #71. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes problem happens during second and further converge, trying to overwrite monit binary file while the file is already opened and not writable.
The binary install recipe now detects following 3 cases and behaves differently:
case 1) Binary file not found
the recipe download binary and installs it
case 2) Binary file found and different version need to be installed
the recipe delete the binary file as there is case it's running and not writable, and download and installs new one
case 3) Binary file found and same version as the one to be installed
skips download and installation