Add Compiler as a container service #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a factory for the `Compiler` class, and adds it to the `ConfigProvider`. Simplifies logic in the `PhpFileFilter` and makes the exceptions it throws for non-existent directories more specific.
If not present, defaults to hard-coding one. `CompileCommandFactory` now pulls the `Compiler` from the container when creating the command instance.
The PHPUnit workflow uses Composer to install deps, which is now on v2. As such: - We need to allow usage of laminas-dependency-plugin v2. - We need to remove the `--no-suggest` option from composer invocation.
First that supports Composer v2.
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
force-pushed
the
feature/compiler-service
branch
from
479fce5
to
a850c1f
Compare
Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the
PhlyBlog\Compilerclass as a service to the DI container, with a factory for creating it, and modifies theCompileCommandto optionally accept aCompilerinstance to its constructor.The
CompileCommandFactorynow pulls theCompilerservice to inject it into theCompileCommandas well.These changes allow users to add a delegator factory in order to listen to the
compileevent.Fixes #28