Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmarklet doesn't work on every site #2

Closed
vetegromedia opened this issue Oct 24, 2013 · 4 comments
Closed

Bookmarklet doesn't work on every site #2

vetegromedia opened this issue Oct 24, 2013 · 4 comments

Comments

@vetegromedia
Copy link

The bookmarklet doesn't work on every site. F.e. Facebook, Twitter or such kind of sites the bookmarklet wont work. Also sites with lightboxes- It seems all sites with JS in it wont work.
@phoboslab
Copy link
Owner

I'm sorry, but I currently have no intentions to work on Asaph. I do however accept pull requests, if you want to fix this yourself.

@eeezyy
Copy link

eeezyy commented Oct 25, 2013

Does it happen on websites over https ?
Then it's not an issue from the bookmarklet but a security issue.

@vetegromedia
Copy link
Author

Yes, All these sites using https!

@phoboslab
Copy link
Owner

Fixed in #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eeezyy @phoboslab @vetegromedia