Adding support for grabbing content from HTTPS sites. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMPORTANT: your Asaph site needs to be provisioned for both HTTP and HTTPS. HTTP source sites use your HTTP Asaph site, HTTPS source sites automatically use your HTTPS Asaph site. The bookmarklet will call your Asaph site in the same protocol that the source site uses. The Asaph script injects code into the source page using the appropriate protocol. For example, 500px.com always uses HTTPS and the Asaph bookmarklet will call your Asaph site using HTTPS. Site tumblr.com is using HTTP and the Asaph bookmarklet will call your Asaph using HTTP.
|
Awesome, thank you! |
|
I have got an error in the console when i click the bookmarklet. https://www.tumblr.com/explore/window.location.protocol+//www.mysite.com/fave/admin/post.js.php and my bookmarklet's link is javascript:void((function()%7Bvar e%3Ddocument.createElement(%27script%27)%3Be.type%3D%27text/javascript%27%3Be.src%3D%27window.location.protocol%2B//www.mysite.com/fave/admin/post.js.php%27%3Bdocument.body.appendChild(e)%7D)())%3B |
|
It seems a wrongly placed single quote is to blame. By the way: Asaph won't work with tumblr.com/explore (the Asaph window won't show) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: your Asaph site needs to be provisioned for both HTTP and HTTPS. HTTP source sites use your HTTP Asaph site, HTTPS source sites automatically use your HTTPS Asaph site.
The bookmarklet will call your Asaph site in the SAME protocol that the source site uses. The Asaph script injects code into the source page using the appropriate protocol.
For example, 500px.com always uses HTTPS and the Asaph bookmarklet will call your Asaph site using HTTPS. Site tumblr.com is using HTTP and the Asaph bookmarklet will call your Asaph using HTTP.