Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions JSDoc update #1233

Closed
plata opened this issue Jan 31, 2021 · 4 comments
Closed

GitHub actions JSDoc update #1233

plata opened this issue Jan 31, 2021 · 4 comments

Comments

@plata
Copy link
Collaborator

plata commented Jan 31, 2021

We cannot push to master from GitHub actions. If we change the JSDoc in every PR, this will produce conflicts.

@plata
Copy link
Collaborator Author

plata commented Jan 31, 2021

@madoar
Copy link
Collaborator

madoar commented Jan 31, 2021

Alternatively we could think about pushing to a separate jsdoc branch. In addition this should only activate on pushes to the master branch. Ideally a new PR would be created as well.

@plata
Copy link
Collaborator Author

plata commented Jan 31, 2021

Yes, but this also has some drawbacks. E.g. what happens if the jsdoc branch is not merged before the action wants to create it again? In general, I would like to avoid manual interaction.

@madoar
Copy link
Collaborator

madoar commented Jan 31, 2021

E.g. what happens if the jsdoc branch is not merged before the action wants to create it again? In general, I would like to avoid manual interaction.

In this case it should not recreate the jsdoc branch instead it should try to update it. If it is needed we could also think about doing a force push to the jsdoc branch

plata added a commit that referenced this issue Feb 1, 2021
As explained in #1233, this should not be the final solution. However, it will work for the meantime while not too many PRs must be handled in parallel.
@plata plata closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants