Allow skipping assets optimization #158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes
Based on our discussion in #154 I propose using
NODE_ENV
to skip assets minification when necessary.NODE_ENV=development mix dev
will run webpack in development mode - in this mode minification steps are ignored.This allows us to easily debug JS code.
Comment/Question
Typically we would expect webpack to run in
development
mode by default and switch toproduction
when necessary (ie. during deployment).I just didn't want to mess with our current workflow - if I changed the default to
development
we would have to remember to always build assets in production mode before submitting them.Or maybe it's not a big deal and I should just use
development
as the default env?Resolves #150