-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#33 Feature nuget packages #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of changes spread out as I just attempted to get this to work in a packaged format.
I'm pretty sure there is a better way than the .bat file, but we'll get there. I didn't want to go too crazy on build scripts until I can take to Nick in detail about this.
Procon.csproj no longer requires reference to Procon.Service.exe. I don't know why it did in the first place..
Since Nuget does everything for us we no longer need the zip functionality ourselves.
Also made Localization and game Config loading functional again
Since we could support protocols that are not actually games, like Teamspeak or something.
It's no longer used at all.
Allows people to use any custom localization files that won't be overwritten by procon or its updates
This is just for unit testing which won't exist in the packages directory.
No longer needed as the controllers are not longer serialized, only the models.
It's mostly there, just need to add the signal propagation then unit tests.
The service will now panic and update itself if it has been offline for 15 minutes or longer. It will repeat this process every 20 minutes. This will help Procon recover from a bad update release.
Requires unit tests to be written for the entire process still
Cache building is now half done outside of the packages controller
Tracking strings in random files is never fun.
Minor test but the fallout from not testing it and some one refactoring is pretty big. It's happened before with plugins in Procon 1.x where people come into the project, refactor without thought of potential fallout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the package management of Procon over to use Nuget packages. Plugins, protocols, core and network functionality can now be distributed and updated with Nuget packages.