Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix clientside errors #166

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Attempt to fix clientside errors #166

merged 3 commits into from
Nov 9, 2020

Conversation

djtb2924
Copy link
Contributor

Hello, my players have many photon errors that I have tried to fix in this 3 commits, you have the concerned errors in each commits decriptions.

(I haven't tested this ingame, it's only theoretical)

@djtb2924
ChatPrint() to chat.AddText()
75f78db 
Fix this :
[ERROR] lua/autorun/photon/cl_photon_eng.lua:551: attempt to call method 'ChatPrint' (a nil value)
  1. unknown - lua/autorun/photon/cl_photon_eng.lua:551
@djtb2924
Added checks for functions used
3160673 
Fixes this :

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:109: attempt to call method 'Photon_Illumination' (a nil value)
  1. fn - lua/autorun/photon/cl_emv_listener.lua:109
   2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:115: attempt to call method 'Photon_Illumination' (a nil value)
  1. fn - lua/autorun/photon/cl_emv_listener.lua:115
   2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:147: attempt to call method 'Photon_Lights' (a nil value)
  1. fn - lua/autorun/photon/cl_emv_listener.lua:147
   2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:150: attempt to call method 'Photon_Lights' (a nil value)
  1. fn - lua/autorun/photon/cl_emv_listener.lua:150
   2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:157: attempt to call method 'Photon_Siren' (a nil value)
  1. fn - lua/autorun/photon/cl_emv_listener.lua:157
   2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:163: attempt to call method 'Photon_Lights' (a nil value)
  1. fn - lua/autorun/photon/cl_emv_listener.lua:163
   2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:171: attempt to call method 'Photon_Lights' (a nil value)
  1. fn - lua/autorun/photon/cl_emv_listener.lua:171
   2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109
@djtb2924
Improve check for EMVU.Helper:GetTASequence
0f391d2 
Fix : 
[Photon Lighting Engine] lua/autorun/photon/sh_emv_helper.lua:272: attempt to index a nil value
  1. GetTASequence - lua/autorun/photon/sh_emv_helper.lua:272
   2. FetchUsedLights - lua/autorun/photon/sh_emv_helper.lua:403
    3. Photon_CalculateUsedLights - lua/autorun/photon/cl_emv_meta.lua:183
     4. Photon_GetELUsedLights - lua/autorun/photon/cl_emv_meta.lua:178
      5. Photon_UpdateFrameLightPositions - lua/autorun/photon/cl_emv_meta.lua:324
       6. Photon_RenderEL - lua/autorun/photon/cl_emv_meta.lua:390
        7. DrawEMVLights - lua/autorun/photon/cl_emv_init.lua:44
         8. fn - lua/autorun/photon/cl_emv_init.lua:92
JoshPiper
JoshPiper reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@JoshPiper JoshPiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for the PR, and thanks for the fixes.
Just a quick question, do you know which error the emv_listener change fixes?

@djtb2924
Copy link
Contributor Author

Yup, them :

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:109: attempt to call method 'Photon_Illumination' (a nil value)

  1. fn - lua/autorun/photon/cl_emv_listener.lua:109
  2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:115: attempt to call method 'Photon_Illumination' (a nil value)

  1. fn - lua/autorun/photon/cl_emv_listener.lua:115
  2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:147: attempt to call method 'Photon_Lights' (a nil value)

  1. fn - lua/autorun/photon/cl_emv_listener.lua:147
  2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:150: attempt to call method 'Photon_Lights' (a nil value)

  1. fn - lua/autorun/photon/cl_emv_listener.lua:150
  2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:157: attempt to call method 'Photon_Siren' (a nil value)

  1. fn - lua/autorun/photon/cl_emv_listener.lua:157
  2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:163: attempt to call method 'Photon_Lights' (a nil value)

  1. fn - lua/autorun/photon/cl_emv_listener.lua:163
  2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

[Photon Lighting Engine] lua/autorun/photon/cl_emv_listener.lua:171: attempt to call method 'Photon_Lights' (a nil value)

  1. fn - lua/autorun/photon/cl_emv_listener.lua:171
  2. unknown - addons/ulib/lua/ulib/shared/hook.lua:109

@creator2013
Copy link
Member

Can you send me the error for ChatPrint aswell? Because according to the wiki LocalPlayer() should return a valid entity. I am just curious why it needs replacement now.

@djtb2924
Copy link
Contributor Author

djtb2924 commented Oct 14, 2020 •
edited
Loading

[ERROR] lua/autorun/photon/cl_photon_eng.lua:551: attempt to call method 'ChatPrint' (a nil value)

  1. unknown - lua/autorun/photon/cl_photon_eng.lua:551

I think it's because networking functions aren't setup totally here.
(all are from clientside_errors.txt)

@djtb2924
Copy link
Contributor Author

Tested in prod (3x 75players for 2 days), no errors !

@JoshPiper JoshPiper merged commit 0643084 into photonle:development Nov 9, 2020
@JoshPiper
Copy link
Member

Cheers @djtb2924 for the PR.

@creator2013 creator2013 mentioned this pull request Jan 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshPiper JoshPiper JoshPiper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djtb2924 @creator2013 @JoshPiper