Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflows #330

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Update workflows #330

merged 2 commits into from
Jan 18, 2023

Conversation

snk4tr
Copy link
Contributor

@snk4tr snk4tr commented Jan 18, 2023

Closes #329

Proposed Changes

  • Fixes CI/CD pipelines that fail on new PRs.

@snk4tr snk4tr self-assigned this Jan 18, 2023
@snk4tr snk4tr added the bug Something isn't working label Jan 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@snk4tr snk4tr changed the title initial changes in python versions Update workflows Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023 •
edited
Loading

Codecov Report

Merging #330 (1baae4b) into master (26d044e) will decrease coverage by 2.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   94.04%   91.95%   -2.10%     
==========================================
  Files          34       34              
  Lines        2485     2485              
==========================================
- Hits         2337     2285      -52     
- Misses        148      200      +52
Flag Coverage Δ
unittests 91.95% <ø> (-2.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
piq/gs.py 32.96% <0.00%> (-57.15%) ⬇️

@snk4tr snk4tr marked this pull request as ready for review January 18, 2023 18:01
denproc
denproc approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@denproc denproc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot on!
LGTM

@denproc denproc merged commit 27db4f3 into master Jan 18, 2023
@snk4tr snk4tr deleted the fix-actions branch January 18, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denproc denproc denproc approved these changes

Assignees

@snk4tr snk4tr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI/CD pipelines need to be updated
2 participants
@snk4tr @denproc