Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable_amqp parameter. Resolves #57 #105

Closed
wants to merge 1 commit into from
Closed

Conversation

kix
Copy link

@kix kix commented Mar 26, 2013

It appears to me that it's not the unavailability that we want to catch. I think the smarter way is to allow the app to be configured for ignoring the AMQP layer at all, this way I can extract the enable_amqp parameter into an environment specific config file depending on whether I need the queue:

In config.yml:

old_sound_rabbit_mq:
    enable_amqp:       %enable_amqp%

In parameters.yml (this file is in .gitignore usually):

parameters:
    enable_amqp: false

Parameter name can surely be changed to your liking. This affects the env-specific config file as well as the DI extension.

@blaugueux
Copy link
Contributor

I don't understand the purpose of this PR. It has the same effect that the sandbox mode ?

@kix
Copy link
Author

kix commented Apr 11, 2013

Whoops, it is really redundant. Closing.
However, sandbox mode is not documented in any way, and that seems like an issue.

@kix kix closed this Apr 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants